Add configuration option to capture JDBC query parameters #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a configuration option to enable capturing JDBC query parameters as span attributes, exposing the upstream OpenTelemetry feature from PR #13719.
Changes Made
Configuration Option
Added
captureQueryParametersboolean field to JDBC configuration:JSON Configuration:
{ "instrumentation": { "jdbc": { "captureQueryParameters": true } } }Environment Variable:
Implementation Details
captureQueryParametersfield toDatabaseInstrumentationWithMasking(defaults tofalse)otel.instrumentation.jdbc.capture-query-parametersSmoke Test Infrastructure
JdbcQueryParametersTestwith telemetry processor configurationSecurity Considerations
Following the upstream implementation, this feature:
Current Status
The configuration infrastructure is complete and functional. The feature correctly sets the OpenTelemetry property, but query parameter attributes are not currently being created by the underlying OpenTelemetry JDBC instrumentation. This appears to be an environment-specific issue that needs further investigation.
When the underlying OpenTelemetry instrumentation issue is resolved, this feature will work automatically without any additional changes required.
Fixes #98.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.